Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing actions and tests for lockPostAutosaving, unlockPostAutosaving #18854

Merged

Conversation

@adamsilverstein
Copy link
Contributor

adamsilverstein commented Dec 2, 2019

Description

Add missing actions for #16249

The original PR was missing the actions for the post autosave lock. These are inbtroduced here along with tests.

How has this been tested?

  • Create a new post
  • Make changes and note autosave firing
  • Lock autosaving: in the console, type wp.data.dispatch( 'core/editor' ).lockPostAutosaving( 'mylock' );
  • Make changes, note autosaving does not occur. Regular updates work as expected (clicking the update button)
  • Unlock autosaving: in the console, type wp.data.dispatch( 'core/editor' ).unlockPostAutosaving( 'mylock' );

Types of changes

  • Add actions for lockPostAutosaving and unlockPostAutosaving with matching tests.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@adamsilverstein adamsilverstein marked this pull request as ready for review Dec 2, 2019
@adamsilverstein adamsilverstein requested review from epiqueras and desaiuditd Dec 2, 2019
Copy link
Member

desaiuditd left a comment

Looks good 👍🏼

@adamsilverstein adamsilverstein merged commit cc6e676 into WordPress:master Dec 3, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@adamsilverstein adamsilverstein deleted the adamsilverstein:fix/lockPostAutosaving branch Dec 3, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.