Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of date picker days when used in block #18856

Conversation

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Dec 2, 2019

Description

Currently if the date picker component is used within a block the day header is misaligned due to inherited editor styles. This PR applies specific margin and padding styles at a higher specificity to prevent this overriding.

How has this been tested?

Tested visually

Screenshots

Before:

before-date

After:

after-date

Types of changes

CSS only change

Fixes #17129

@glendaviesnz

This comment has been minimized.

Copy link
Contributor Author

glendaviesnz commented Dec 2, 2019

I am sure there is probably a more generic way to fix these layout errors caused by inheritance of .editor-styles-wrapper styles - but haven't managed to think of it yet.

@youknowriad youknowriad requested a review from jasmussen Dec 2, 2019
Copy link
Contributor

jasmussen left a comment

Tested, and verified this seems to work as intended. Nice work, thank you!

@youknowriad youknowriad merged commit 0671aa6 into WordPress:master Dec 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.