Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding regression with appender #18865

Merged
merged 2 commits into from Dec 2, 2019
Merged

Fix padding regression with appender #18865

merged 2 commits into from Dec 2, 2019

Conversation

@jasmussen
Copy link
Contributor

jasmussen commented Dec 2, 2019

Earlier today, I merged #18105. As part of that, two existing issues were visually surfaced. Technically the bugs were already present, but the issues were masked by the padding rules.

The issue existed in the first place because the appender component compensated for horizontal margins that were refactored away in #17877.

This affected groups and columns that had the placeholder appender.

Group, before:

group before

Group, after:

group after

Columns before:

cols before

Columns after:

cols after

@gziolo
gziolo approved these changes Dec 2, 2019
Copy link
Member

gziolo left a comment

I can't see the jump anymore. Looks good in my testing 👍

@jasmussen jasmussen merged commit b02920d into master Dec 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jasmussen jasmussen deleted the fix/padding-regression branch Dec 2, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.