Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18825: Styles for the toggled state in the ToolbarButton added back #18868

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@gziolo
Copy link
Member

gziolo commented Dec 2, 2019

Description

Fixes #18825.

I noticed that this change created regression for toolbar buttons:
toggled-buttons

When they are toggled they no longer change their visual appearance. This is how it worked before 7.0:

Screen Shot 2019-11-29 at 15 38 14

It was introduced in #18631.

An alternative to #18860.

After

Screen Shot 2019-12-02 at 13 10 48

Screen Shot 2019-12-02 at 13 11 15
Screen Shot 2019-12-02 at 13 11 35

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Dec 2, 2019

The only issue I see is:

Screen Shot 2019-12-02 at 13 01 40

However, it's something that exists in the master as well for focused and hovered buttons:

Screen Shot 2019-12-02 at 13 12 58

Copy link
Contributor

jasmussen left a comment

toggles

Nice. Very nice.

@gziolo

This comment has been minimized.

Copy link
Member Author

gziolo commented Dec 2, 2019

I moved the styles to the ToolbarButton component after talking with @youknowriad. In my testing, it works the same, but it's scoped more strictly.

Copy link
Contributor

youknowriad left a comment

LGTM

@gziolo gziolo merged commit b03317e into master Dec 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@gziolo gziolo deleted the fix/toolbar-button-toggled branch Dec 2, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.