Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Post: Render metaboxes as single seamless unit #18873

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

@aduth
Copy link
Member

aduth commented Dec 2, 2019

Related: #18044, #18762

This pull request seeks to improve styling interoperability between the meta box area and a themed editor background. As seen in the "Before" screenshot below, there is a plain-white margin gap which appears above the meta box area. With these changes, the margin is removed, and meta boxes changed to being contained within a single container element.

Before After
Before After

Testing Instructions:

In the default development environment, you can enable the "Gutenberg Test Plugin, Meta Box" plugin to display a meta box in the metabox area.

Furthermore, I used Advanced Custom Fields to add many more meta boxes. ACF does not appear to have the option to make a meta box for the "advanced" context, so I tested this by manually editing this line to 'advanced',.

  1. Navigate to Posts > Add New
  2. Verify with meta boxes shown, or with no meta boxes shown, that there is no gap between meta box area (if present) and the rest of the editor canvas
Copy link
Member

karmatosed left a comment

From design feedback, approving this PR. Great little tidy up.

@aduth aduth merged commit d89595b into master Dec 3, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the update/meta-margins branch Dec 3, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.