Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reusable blocks being too tall #18902

Merged
merged 1 commit into from Dec 5, 2019
Merged

Fix reusable blocks being too tall #18902

merged 1 commit into from Dec 5, 2019

Conversation

@ZebulanStanphill
Copy link
Contributor

ZebulanStanphill commented Dec 4, 2019

Description

Fixes #18901. The issue was caused by #18732 changing a height style rule to a min-height rule, while not changing the styling in packages/block-library/src/block/editor.scss that was intended to override it.

Screenshots

Before:
image

After:
image

Copy link
Contributor

draganescu left a comment

LGTM!

@ZebulanStanphill ZebulanStanphill merged commit da0b001 into master Dec 5, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ZebulanStanphill ZebulanStanphill deleted the fix/18901 branch Dec 5, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
scruffian added a commit to scruffian/gutenberg that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.