Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Reintroduce LTS support commitment #18923

Merged
merged 3 commits into from Dec 6, 2019
Merged

Docs: Reintroduce LTS support commitment #18923

merged 3 commits into from Dec 6, 2019

Conversation

@aduth
Copy link
Member

aduth commented Dec 4, 2019

Previously: #17004

This pull request seeks to document the expected supported versions of Node required for running this project. Prior to #17004, we explicitly mentioned the current active LTS as being required. In order to avoid ambiguity on what is to be supported (example), this support commitment should be documented. The "Getting Started" document may not be the best place for this, but it at least serves as a point of reference.

Testing Instructions:

The changes include only documentation changes. There is no expected impact on application runtime.

docs/contributors/getting-started.md Outdated Show resolved Hide resolved
@gziolo
gziolo approved these changes Dec 5, 2019
Copy link
Member

gziolo left a comment

👍

Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
@aduth

This comment has been minimized.

Copy link
Member Author

aduth commented Dec 5, 2019

At #18840 (comment), @nosolosw mentions a good point, which I don't think we'd considered before; that even within "active LTS", there's a potential ambiguity (there are currently two active LTS releases). I believe the behavior of nvm with our lts/* configuration will always install the latest active LTS. Maybe it's enough to include this additional "latest" adjective to further clarify the intended target.

@aduth aduth merged commit 72d9bd0 into master Dec 6, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the restore/lts-commitment branch Dec 6, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.