Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a `type=submit` to the search suggestion buttons #18933
Recently pressing enter to submit a url as a navigation link in the nav block stopped working. It looks like the
How has this been tested?
e2e tests are being worked on in #18929, which is how this was discovered.
Types of changes
Bug fix (non-breaking change which fixes an issue)
When I click on a search result in the navigation block search suggestions, I see a console warning:
I have also observed that this can cause end-to-end test failures:
I expect that since this button is also assigned an
The root cause of this is a bit further in the past—previously these suggestions were using
A fix could involve suggestions being handled by