Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: fix expandOnMobile #18936

Merged
merged 5 commits into from Dec 5, 2019
Merged

Popover: fix expandOnMobile #18936

merged 5 commits into from Dec 5, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Dec 5, 2019

Description

  • Fixes expandOnMobile to expand again.
  • Only change the DOM when needed.
  • is-mobile class => is-expanded

How has this been tested?

Test the main inserter button popover on mobile.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
Copy link
Contributor

youknowriad left a comment

Other than the missing JSDocs, this seems to work great and I like the CSS simplification.

@ellatrix ellatrix force-pushed the fix/popover-expand-mobile branch from 317133d to 2137a93 Dec 5, 2019
@ellatrix ellatrix requested review from noisysocks and Soean as code owners Dec 5, 2019
@ellatrix ellatrix force-pushed the fix/popover-expand-mobile branch from 0bdce5a to 3917fa5 Dec 5, 2019
@ellatrix ellatrix force-pushed the fix/popover-expand-mobile branch from 3917fa5 to 129636c Dec 5, 2019
@ellatrix ellatrix merged commit 49dac29 into master Dec 5, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ellatrix ellatrix deleted the fix/popover-expand-mobile branch Dec 5, 2019
scruffian added a commit to scruffian/gutenberg that referenced this pull request Dec 10, 2019
* Popover: fix expandOnMobile

* Diff attributes

* Add docs

* Use number checks when adding px

* Remove more instances of :not(.is-mobile)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.