Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the inspector controls for the navigation block #18948

Merged
merged 5 commits into from Dec 6, 2019

Conversation

@draganescu
Copy link
Contributor

draganescu commented Dec 5, 2019

Description

There currently are no sidebar options for the Navigation Block but there is one option who just remained there from the initial testing: automatically add new pages to the menu. This option does nothing if set.

How has this been tested?

The option is gone.

@draganescu draganescu added this to 👀 PRs to review in Navigation block via automation Dec 5, 2019
@draganescu draganescu self-assigned this Dec 5, 2019
@getdave getdave self-requested a review Dec 6, 2019
@getdave
getdave approved these changes Dec 6, 2019
Copy link
Contributor

getdave left a comment

I tested this and I can confirm the controls have been removed.

I agree that they are not required as they don't really do anything.

@talldan

This comment has been minimized.

Copy link
Contributor

talldan commented Dec 6, 2019

Looks good to me too. Tests are failing due to some linting errors though, but I can't actually see those errors when I check out the code 🤔

@talldan

This comment has been minimized.

Copy link
Contributor

talldan commented Dec 6, 2019

Lemme try a rebase.

edit: Looks like the attribute declarations were missed, so just removing those.

@talldan talldan force-pushed the fix/no-autopages-in-nav branch from f0a993c to e5643c6 Dec 6, 2019
@draganescu draganescu requested review from nerrad and ntwb as code owners Dec 6, 2019
@talldan

This comment has been minimized.

Copy link
Contributor

talldan commented Dec 6, 2019

Rebased and the new alignments code in the nav block uses attributes and setAttributes, so had to add those back to solve the linting errors.

@talldan
talldan approved these changes Dec 6, 2019
@talldan talldan merged commit 1922d8c into master Dec 6, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Dec 6, 2019
@talldan talldan deleted the fix/no-autopages-in-nav branch Dec 6, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
scruffian added a commit to scruffian/gutenberg that referenced this pull request Dec 10, 2019
)

* removes the inspector controls for the navigation block as they had no functionality

* removes the second place where we had the non functional auto add pages functionality

* Remove automaticallyAdd attribute

* Update tests

* Add back attributes and setAttributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.