Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo and improve clarity for "Keeping Your Fork Up To Date" section #18961

Conversation

@edmundcwm
Copy link
Contributor

edmundcwm commented Dec 6, 2019

Instructions provided for syncing your Fork might seem a bit confusing as the commands given are for syncing your Local copy instead:

git fetch upstream
git checkout master
git merge upstream/master

To improve clarity, we can mention that users need to first sync their Local copy using the commands above. After that's done, they can do a git push to push the changes and sync their Fork.

docs/contributors/git-workflow.md Outdated Show resolved Hide resolved
docs/contributors/git-workflow.md Outdated Show resolved Hide resolved
edmundcwm and others added 2 commits Dec 6, 2019
Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
@ZebulanStanphill ZebulanStanphill merged commit 3ab0c2a into WordPress:master Dec 6, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@edmundcwm edmundcwm deleted the edmundcwm:update/docs-contributors-git-workflow branch Dec 7, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.