Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18151 #18964

Merged
merged 2 commits into from Dec 7, 2019
Merged

Fix #18151 #18964

merged 2 commits into from Dec 7, 2019

Conversation

@Shizumi
Copy link
Contributor

Shizumi commented Dec 6, 2019

Description

It was difficult to translate because of a line break problem.
Fixes #18151

How has this been tested?

npm run test and check actual display

Screenshots

スクリーンショット 2019-12-06 14 13 00

Types of changes

Bug fix (non-breaking change which fixes an issue)

@youknowriad youknowriad requested review from mcsf and ellatrix Dec 6, 2019
__( 'registerBlockType( name, settings );' ),
content: sprintf(
__( '// A "block" is the abstract term used%1$s// to describe units of markup that%1$s// when composed together, form the%1$s// content or layout of a page.%1$sregisterBlockType( name, settings );' ),
'\n'

This comment has been minimized.

Copy link
@ellatrix

ellatrix Dec 6, 2019

Member

I think it's fine to just place the line breaks within the string? Cc @mcsf

This comment has been minimized.

Copy link
@mcsf

mcsf Dec 6, 2019

Contributor

Yes, please. A translators note could be added just in case, e.g.

// translators: Preserve \n markers for line breaks
__( '// A "block" is the abstract term used\nto describe units of markup that,…

This comment has been minimized.

Copy link
@Shizumi

Shizumi Dec 6, 2019

Author Contributor

Thank you, everyone.
Correspond.

@mcsf
mcsf approved these changes Dec 6, 2019
Copy link
Contributor

mcsf left a comment

Thanks for the fix!

@mcsf mcsf merged commit 498b20a into WordPress:master Dec 7, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth

This comment has been minimized.

Copy link
Member

aduth commented Dec 7, 2019

Was this meant to remove localization altogether? The changes appear to have turned this to a plain string (i.e. all __ localization functions were removed).

@Shizumi

This comment has been minimized.

Copy link
Contributor Author

Shizumi commented Dec 8, 2019

I'm sorry.
"" was deleted by mistake.
The actual intention is not to delete "
" but to set it as a single string that will not be split.
I want to fix it, what should I do?

@aduth

This comment has been minimized.

Copy link
Member

aduth commented Dec 8, 2019

(For posterity's sake, follow-up is at #19001)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.