Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
i18n: Add ‘translators’ note to Code block example #18993
Ouch. For context, I opened this very PR from my phone as a follow-up to that one, but somehow I missed the disappearance of
This is a great question that I hadn't considered. Looking up a string in GlotPress seems to confirm that there's nothing in place to preserve translator notes.
@Soean It's likely, yes. I remember some initial discussion of this when the tooling around string extraction was changed toward relying on the plugin repository (I believe it's the same as in WP-CLI's i18n command).
In any case, I don't know that it's been explored yet, the most direct solution here would seem to be some configuration of Uglify/Terser to allow these comments to remain. This configuration exists already, typically used for copyright/license headers. I think it can be reused for this purpose.
I've created #19006 to track this.