Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Remove block inserter shortcuts #19045

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

@aduth
Copy link
Member

aduth commented Dec 10, 2019

Related: #10519, #4951
Partially addresses #5055

This pull request seeks to remove the block inserter "shortcuts" which would previously appear when hovering the "appender" area below the list of blocks in the block editor.

Needs Design/Accessibility Feedback: It is proposed that they be removed due to:

  • Confusion around how they appear (#5055) and the expected options they include (#18251)
  • Accessibility issues including expected tab grouping order (#10519 (comment))
  • Design concerns around the allotment of available space in narrow viewports (#19033 (comment))
  • Anecdotal assessments that these shortcut options do not provide meaningful benefit to the user experience (related Slack discussion).

Their removal yields a simplification, both in the technical implementation and to the benefit of users in reducing the surface area of block insertion options.

Before After
Before After

Testing Instructions:

Verify there are no regressions in the insertion of blocks, specifically in using the "default" appender, which is expected to show either when:

  1. The post is empty
  2. The last block is a selected, empty paragraph
  3. The last block is a non-paragraph

(It's acknowledged that the above logic flow is still prone to confusion, which could be addressed in subsequent improvements surrounding #10519)

The "+" button should still be shown where the "shortcuts" would have previously been expected to appear, to the left of the block list.

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Dec 10, 2019

I've considered this as well for some time now. I agree that they don't bring much value. Any perspective here @ZebulanStanphill @jasmussen @mapk

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Dec 10, 2019

Remove them! I've not used them once.

@chrisvanpatten

This comment has been minimized.

Copy link
Member

chrisvanpatten commented Dec 10, 2019

Goodbye inserter shortcuts, you will not be missed 👋

@ellatrix

This comment has been minimized.

Copy link
Member

ellatrix commented Dec 10, 2019

Yes please!

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

ZebulanStanphill commented Dec 10, 2019

I never use the inserter shortcut buttons. The slash inserter is faster and more useful.

I'd go a step further and change the empty Paragraph inserter to look the same as it does for nested blocks, since having the icon to the left and outside of the block border is kind of confusing.

@karmatosed

This comment has been minimized.

Copy link
Member

karmatosed commented Dec 11, 2019

+1 to remove :)

@aduth

This comment has been minimized.

Copy link
Member Author

aduth commented Dec 11, 2019

I'd go a step further and change the empty Paragraph inserter to look the same as it does for nested blocks, since having the icon to the left and outside of the block border is kind of confusing.

Do you think this would be fine for a follow-up pull request, or is the need for this directly impacted by the removal of the shortcuts? Given the likelihood that discussions surrounding #10519 can stagnate, I'm inclined to push for more incremental steps.

I sense what you're suggesting is similar to what was explored in #11329, which was closed in part due to lingering questions around (intentional?) differences between top-level and nested block inserters (#11329 (comment)).

@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Dec 11, 2019

I've also found they cause confusion for users who hover over them wondering what they are and if they're what they need.

I'm for removing them.

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

ZebulanStanphill commented Dec 11, 2019

@aduth I'm fine with just removing the block inserter shortcuts for now. However, I do think that with them gone, there is little reason to have the inserter look different at the top level vs. nested contexts.

Copy link
Contributor

youknowriad left a comment

Let's do it.

@shaunandrews

This comment has been minimized.

Copy link

shaunandrews commented Dec 18, 2019

Do it!

@aduth aduth force-pushed the remove/block-appender-shortcuts branch from 9ff70d4 to 7f5ff74 Dec 20, 2019
@aduth aduth merged commit 14401e0 into master Dec 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the remove/block-appender-shortcuts branch Dec 20, 2019
@ellatrix ellatrix mentioned this pull request Jan 6, 2020
0 of 6 tasks complete
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.