Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Developer Tools setup in Getting Started #19074

Merged
merged 4 commits into from Dec 20, 2019
Merged

Docs: Add Developer Tools setup in Getting Started #19074

merged 4 commits into from Dec 20, 2019

Conversation

@mkaz
Copy link
Member

mkaz commented Dec 11, 2019

Description

Adds a new section for Developer Tools for setting up an editor to the Getting Started page in the Contributors Handbook. The section recommends setting up EditorConfig and Prettier extensions.

This can precede the Prettier PR #18048 to help people get setup prior, wording will just need to be updated after that release to remove references to the PR in the doc.

How has this been tested?

Follow directions on documentation page, found on branch here

Types of changes

Developer docs.

Copy link

griffbrad left a comment

Thanks for ensuring the prettier work is reflected in the docs!

docs/contributors/getting-started.md Outdated Show resolved Hide resolved
@ntwb

This comment has been minimized.

Copy link
Member

ntwb commented Dec 14, 2019

@mkaz, I just added a comment on #18408,

#18048 (comment)

I suspect this will not be an issue, so long as the user does not have a Prettier extension where they have configured the extension settings... I'm wondering if the extension settings would override any settings in the .preetierrc file 🤔

mkaz added 2 commits Dec 17, 2019
@ntwb
ntwb approved these changes Dec 19, 2019
Copy link
Member

ntwb left a comment

Looks good to me 👍🏼

@mkaz mkaz merged commit 334b0b2 into master Dec 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the add/doc-prettier branch Dec 20, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.