Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent select all behavior when shift key is pressed #1908

Closed
wants to merge 1 commit into from

Conversation

@westonruter
Copy link
Member

westonruter commented Jul 15, 2017

Fixes #1850.

@@ -57,6 +57,7 @@ class VisualEditor extends Component {
if (
! isEditableElement( document.activeElement ) &&
( event.ctrlKey || event.metaKey ) &&
! event.shiftKey &&

This comment has been minimized.

Copy link
@ellatrix

ellatrix Jul 18, 2017

Member

I would prefer that we add a utility function similar to the one in TinyMCE core, because I think we'll need to do this in a few other (future) places. It's also good to describe with the function name what exactly we are blocking. In some cases this would be only the meta key, in others all modifiers. https://github.com/tinymce/tinymce/blob/4.6.4/src/core/src/main/js/util/VK.js

This comment has been minimized.

Copy link
@westonruter

westonruter Jul 18, 2017

Author Member

Amend the PR with what you have in mind?

@westonruter

This comment has been minimized.

Copy link
Member Author

westonruter commented Jul 19, 2017

Closing in favor of #1944.

@westonruter westonruter deleted the fix/shift-select-all branch Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.