Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the new replace flow to the audio block #19158

Merged
merged 4 commits into from Jan 7, 2020
Merged

Conversation

@draganescu
Copy link
Contributor

draganescu commented Dec 16, 2019

Description

There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Audio Block.

How has this been tested?

Tested locally.

Screenshots

Screenshot 2019-12-16 at 10 41 36

@draganescu draganescu force-pushed the add/media-flow-audio-block branch from 3cf917e to bdbdbfe Dec 16, 2019
@draganescu draganescu removed their assignment Dec 19, 2019
Copy link
Member

Soean left a comment

The replacement flow works great. I added just a little suggestion.

packages/block-library/src/audio/edit.js Outdated Show resolved Hide resolved
@Soean

This comment has been minimized.

Copy link
Member

Soean commented Dec 29, 2019

This PR fixes #16048

@draganescu draganescu force-pushed the add/media-flow-audio-block branch from bdbdbfe to d7681fa Jan 6, 2020
@draganescu draganescu requested a review from Soean Jan 6, 2020
…enberg into add/media-flow-audio-block
@Soean
Soean approved these changes Jan 6, 2020
Copy link
Member

Soean left a comment

Thanks, code looks good and replacement works.

@draganescu draganescu merged commit 55a3b35 into master Jan 7, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the add/media-flow-audio-block branch Jan 7, 2020
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.