Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the new replace flow to the video block #19162

Merged
merged 3 commits into from Jan 7, 2020
Merged

Conversation

@draganescu
Copy link
Contributor

draganescu commented Dec 16, 2019

Description

There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Audio Block.

How has this been tested?

Tested locally.

Screenshots

Screenshot 2019-12-16 at 13 27 34

@draganescu draganescu self-assigned this Dec 16, 2019
@draganescu draganescu force-pushed the add/media-flow-video-block branch from 152aa55 to f923d8f Dec 16, 2019
@draganescu draganescu removed their assignment Dec 19, 2019
Copy link
Member

Soean left a comment

The replacement flow works great 👍. If we don't use the state editing anymore, we can remove it from this component.

@draganescu draganescu force-pushed the add/media-flow-video-block branch from f923d8f to 960fdaa Jan 6, 2020
@draganescu

This comment has been minimized.

Copy link
Contributor Author

draganescu commented Jan 6, 2020

Hi @Soean I removed the useless state in 960fdaa. Thank you for reviewing all these!

@draganescu draganescu requested a review from Soean Jan 6, 2020
@Soean
Soean approved these changes Jan 6, 2020
Copy link
Member

Soean left a comment

Works great.
We can remove some old comments. Maybe we can do it in another PR.

@@ -47,10 +47,6 @@ class VideoEdit extends Component {
super( ...arguments );
// edit component has its own src in the state so it can be edited

This comment has been minimized.

Copy link
@Soean

Soean Jan 6, 2020

Member

The src state was removed in #6820, so we can remove this comment.

@@ -95,8 +90,7 @@ class VideoEdit extends Component {
const { attributes, setAttributes } = this.props;
const { src } = attributes;

// Set the block's src from the edit component's state, and switch off
// the editing UI.
// Set the block's src from the edit component's state

This comment has been minimized.

Copy link
@Soean

Soean Jan 6, 2020

Member

We also can remove this comment, it's not valid since #6820

@Soean
Soean approved these changes Jan 7, 2020
Copy link
Member

Soean left a comment

Works great, so we can merge it.

@draganescu draganescu merged commit 7ccb5ae into master Jan 7, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the add/media-flow-video-block branch Jan 7, 2020
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.