Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse block: fix white space #19173

Merged
merged 1 commit into from Dec 17, 2019
Merged

Verse block: fix white space #19173

merged 1 commit into from Dec 17, 2019

Conversation

ellatrix
Copy link
Member

Description

Fixes #19083. Since #18372, the verse block uses character line breaks instead of element line breaks. Unfortunately, I seem to have missed correcting the styles on the front end to be pre-style.

How has this been tested?

Create a verse block with two lines. View the front end. There should be two lines.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Block] Verse Affects the Verse block labels Dec 16, 2019
@ellatrix ellatrix requested a review from mcsf December 16, 2019 15:28
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we both missed this 😓 — LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Verse Affects the Verse block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verse block new lines are not rendered
3 participants