Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new media flow to the media text block #19198

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Dec 17, 2019

Description

Requires #18139 There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Media + Text block.

How has this been tested?

Tested locally.

Screenshots

Screenshot 2019-12-17 at 17 06 37

@draganescu draganescu changed the title Add the new media flow to the media text block wip: Add the new media flow to the media text block Dec 17, 2019
@draganescu draganescu changed the title wip: Add the new media flow to the media text block Add the new media flow to the media text block Dec 18, 2019
@draganescu draganescu force-pushed the add/media-flow-media-text-block branch from 47d9458 to b74fc82 Jan 6, 2020
@draganescu draganescu requested a review from Soean Jan 6, 2020
mediaUrl: newURL,
href: newHref,
mediaId: undefined,
sizeSlug: DEFAULT_SIZE_SLUG,

This comment has been minimized.

Copy link
@Soean

Soean Jan 6, 2020

Member

There is no sizeSlug attribute in the media-text block.

export const LINK_DESTINATION_ATTACHMENT = 'attachment';
const LINK_DESTINATION_MEDIA = 'media';
const LINK_DESTINATION_ATTACHMENT = 'attachment';
const DEFAULT_SIZE_SLUG = 'large';

This comment has been minimized.

Copy link
@Soean

Soean Jan 6, 2020

Member

We can remove the default, because there is no sizeSlug attribute.

@Soean
Soean approved these changes Jan 7, 2020
Copy link
Member

Soean left a comment

Thanks, works great!

@draganescu draganescu merged commit 6a940eb into master Jan 7, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the add/media-flow-media-text-block branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.