Add the new media flow to the media text block #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
draganescu
changed the title
draganescu
changed the title
Soean
requested changes
Dec 29, 2019
draganescu
force-pushed
the
add/media-flow-media-text-block
branch
from
47d9458
to
b74fc82
Compare
Soean
requested changes
Jan 6, 2020
| mediaUrl: newURL, | ||
| href: newHref, | ||
| mediaId: undefined, | ||
| sizeSlug: DEFAULT_SIZE_SLUG, |
There was a problem hiding this comment.
There is no sizeSlug attribute in the media-text block.
| export const LINK_DESTINATION_ATTACHMENT = 'attachment'; | ||
| const LINK_DESTINATION_MEDIA = 'media'; | ||
| const LINK_DESTINATION_ATTACHMENT = 'attachment'; | ||
| const DEFAULT_SIZE_SLUG = 'large'; |
There was a problem hiding this comment.
We can remove the default, because there is no sizeSlug attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires #18139 There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Media + Text block.
How has this been tested?
Tested locally.
Screenshots