Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Writing flow: improved tabbing for Edit mode #19235
This PR changes block navigation (tabbing) behaviour for Edit mode, which is needed for #18779. This turns out to be a drastic improvement from the current tabbing experience.
I believe the new tabbing behaviour creates a beautiful balance between edit mode (super easy access to block controls), navigation mode (easy access to other blocks), and traditional editor navigation (arrow keys to access other blocks).
It also reduces the need for the obscure region shortcut
How has this been tested?
Tab around in Edit and Navigation mode.
Types of changes
youknowriad left a comment
it's a little bit weird that that tabbing stops at the first block and then when we start over, the post title is skipped.
I still wonder whether it's better to have the "constraint tabbing" behavior when in edit mode and a block UI is focused but I'll defer to other a11y testers. I believe @MarcoZehe already approved the behavior in this PR.
@youknowriad You're right this this might be possible to improve when you first tab into a block. I feel like you should be in Navigation mode when you first tab to a block. That also make sense as it is the mode you