Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks: Add to Block Manager #19400

Draft
wants to merge 3 commits into
base: master
from
Draft

Conversation

@gziolo
Copy link
Member

gziolo commented Jan 3, 2020

Description

Closes #13390.

WIP

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Jan 4, 2020

The "Manage All Reusable Blocks" link has been removed from the Options popover.

Screen Shot 2020-01-03 at 4 57 24 PM

The Reusable blocks category is now added to the Block Manager along with the "Edit blocks" link.

Screen Shot 2020-01-03 at 4 58 04 PM

@@ -75,6 +75,10 @@
font-size: 0.9rem;
font-weight: 600;
}

> a {
float: right; //Aligning link to the right of category heading.

This comment has been minimized.

Copy link
@gziolo

gziolo Jan 7, 2020

Author Member

It looks like using float changes only the visual appearance but not the tabbing order:
tab-order-block-manager

We need to find a different approach here.

This comment has been minimized.

Copy link
@mapk

mapk Jan 7, 2020

Contributor

Yeah, I was wondering about that. float:right works easier this way, but tab order is off now. I'll fix this.

@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Jan 7, 2020

I've added flexbox to the category title to improve the tab order.

tab-order 2020-01-07 12_43_28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.