Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace, on editing a navigation link, the current label with the title of page or post #19461

Merged
merged 2 commits into from Jan 17, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Jan 7, 2020

Description

Closes #18695

How has this been tested?

Tested locally.

Screenshots

navigation-link-update

Types of changes

Small non-breaking update of the navigation link component that sets the label on link change depending on whether the link is a page or post, or just a link.

@draganescu draganescu changed the title Replaces on editing the link the current label with the title of page or post Replace, on editing a navigation link, the current label with the title of page or post Jan 7, 2020
@draganescu draganescu force-pushed the fix/label-update-on-link-change branch from 54a5863 to b3125bd Jan 15, 2020
Copy link
Contributor

tellthemachines left a comment

All good then! Approving.

@draganescu draganescu force-pushed the fix/label-update-on-link-change branch from 0f8ee6b to 0635dd1 Jan 17, 2020
@draganescu draganescu merged commit 84f530f into master Jan 17, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the fix/label-update-on-link-change branch Jan 17, 2020
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.