Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds always on display of media URL #19504

Open
wants to merge 1 commit into
base: master
from

Conversation

@draganescu
Copy link
Contributor

draganescu commented Jan 8, 2020

Description

Implementation of one of the variants in #18992 about always showing the URL of the current media in the media replace control.

How has this been tested?

Tested locally.

Screenshots

media-replace-show-url

Types of changes

Minimal changes so that the LinkEditor / LinkViewer components do not have to be modified and avoid global impact.

cc: @shaunandrews

@Soean Soean self-requested a review Jan 8, 2020
@shaunandrews

This comment has been minimized.

Copy link

shaunandrews commented Jan 13, 2020

I like it. Two suggestions:

  1. Use a button with a label (instead of a mysterious icon) for the edit action. This matches up with the Link UI, and is also more obvious and clear to users.
  2. Just general cleanup around the layout/display for editing the image URL. Here's a mockup of what I would expect it to look like:

image

@draganescu draganescu force-pushed the add/always-on-url-media-replace branch from b20a223 to 6d5209b Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.