Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: Add a Post Date block. #19578

Merged
merged 3 commits into from Jan 14, 2020
Merged

Block Library: Add a Post Date block. #19578

merged 3 commits into from Jan 14, 2020

Conversation

@epiqueras
Copy link
Contributor

epiqueras commented Jan 11, 2020

Description

This PR adds a new Post Date block akin to the Post Title and Post Content blocks.

How has this been tested?

  • Inserted Post Date block in a post.
  • Confirmed post date rendered in the editor and front end.
  • Inserted Post Date block in a template.
  • Confirmed post date placeholder rendered in the editor and the relevant post date rendered in the front end.

Types of Changes

New Feature: There is a new Post Date block for template building.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
packages/block-library/src/post-date/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/post-date/index.php Outdated Show resolved Hide resolved
@MarcoZehe MarcoZehe mentioned this pull request Jan 11, 2020
5 of 6 tasks complete
@epiqueras epiqueras mentioned this pull request Jan 13, 2020
3 of 9 tasks complete

export const settings = {
title: __( 'Post Date' ),
edit,

This comment has been minimized.

Copy link
@youknowriad

youknowriad Jan 14, 2020

Contributor

a format attribute is definitely needed for this block.

Copy link
Contributor

youknowriad left a comment

Looks good for a start

@epiqueras epiqueras force-pushed the add/post-date-block branch from 8630677 to 31bfb51 Jan 14, 2020
@epiqueras epiqueras requested review from nerrad and ntwb as code owners Jan 14, 2020
@epiqueras epiqueras merged commit eeb13f4 into master Jan 14, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@epiqueras epiqueras added this to Done in Phase 2 via automation Jan 14, 2020
@epiqueras epiqueras deleted the add/post-date-block branch Jan 14, 2020
@ellatrix ellatrix modified the milestones: Future, Gutenberg 7.3 Jan 20, 2020
@karmatosed karmatosed added this to Done in Full site editing Feb 4, 2020
@kjellr kjellr added the New Block label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phase 2
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.