Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if caption is empty in media lib and keeps the one written #19641

Merged
merged 2 commits into from Feb 6, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Jan 14, 2020

Description

Closes #19636

How has this been tested?

Tested locally.

Screenshots

caption-preserved

Types of changes

Basically the behavior was there already but only for the temporary preview.

@draganescu draganescu force-pushed the fix/caption-replaced-by-empty branch from 477494a to 6b49f7c Jan 15, 2020
@draganescu draganescu force-pushed the fix/caption-replaced-by-empty branch from 6b49f7c to 4643556 Jan 16, 2020
@talldan

This comment has been minimized.

Copy link
Contributor

talldan commented Jan 21, 2020

Looks like some tests that need to be sorted @draganescu.

@draganescu

This comment has been minimized.

Copy link
Contributor Author

draganescu commented Jan 23, 2020

@talldan tests pass! I mistakenly was treating alt the same way. Although I could do that in a separate PR, but will also need to alter a test in that case.

Anyway this here is only about the caption.

Copy link
Contributor

tellthemachines left a comment

Code looks good and works as expected. Thanks for fixing this!

@draganescu draganescu merged commit 088032b into master Feb 6, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the fix/caption-replaced-by-empty branch Feb 6, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 6, 2020
chipsnyder added a commit that referenced this pull request Feb 7, 2020
…9641)

* checks if caption is empty in media lib and keeps the one written in block

* removes ALT from the solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.