Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not unmount the sidebar when opening the publish pane #19843

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Jan 23, 2020

Description

Closes #19840
Leaves the sidebar open and in page below the publish panel. In doing so it avoids the content jumping to the right because of new found viewport width.

How has this been tested?

  • Create a new post
  • Open the publish panel
  • The content region has the same width
@draganescu draganescu requested a review from talldan as a code owner Jan 23, 2020
@draganescu

This comment has been minimized.

Copy link
Contributor Author

draganescu commented Jan 23, 2020

@youknowriad I tested this change and it seems to work, but I am afraid I broke something I can't test. Let me know if this rings any bell :)

@draganescu draganescu changed the title Do not unmount the sidebar when opening the publish pane Jan 23, 2020
@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 23, 2020

Try to tab to the publish panel when the sidebar is opened to ensure everything works as expected. The area is after the sidebar. It should show the button to open the publish panel. When you click on it it should open.

@draganescu

This comment has been minimized.

Copy link
Contributor Author

draganescu commented Jan 24, 2020

Thanks @gziolo tabbing works perfectly. Still couldn't spot any issues.

Copy link
Contributor

tellthemachines left a comment

I checked this with the keyboard: navigating through regions the 'Open Publish Panel' comes after the sidebar as expected, and the publish panel can be opened from there. Once in the panel, focus is captured, as expected, so I am unable to tab outside unless I close the panel or use the regions shortcut (ctrl + ~). With that shortcut it is still possible to tab through the hidden sidebar buttons. It's a bit of an edge case though, as it would be hard to do it by accident.
Overall, it works very well!

@draganescu draganescu force-pushed the fix/editor-move-on-publish branch from 564fea2 to 355854f Feb 6, 2020
@draganescu draganescu merged commit 59d3f61 into master Feb 6, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the fix/editor-move-on-publish branch Feb 6, 2020
@ellatrix ellatrix added this to the Gutenberg 7.5 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.