Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: set inherit color to anchor elements #20038

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@retrofox
Copy link
Contributor

retrofox commented Feb 4, 2020

Description

It sets the color of the anchor elements when the Navigation menu has defined a text color. It fixes coloring issues for some themes.

How has this been tested?

Tested with Maywood, Twenty-Seventeen themes:

  1. Create a Navigation menu
  2. Set (only) text color

  1. Save

before
4) In the front-end, confirm that the color is not applied on the menu.
image

after
5) Confirm that the color is rightly applied ob the menu, in the front-end.
Screen Shot 2020-02-04 at 1 56 25 PM

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
It sets the color of the anchor elements when the Navigation menu has defined a text color. It fixes coloring issues for some themes.
@retrofox retrofox requested review from jeryj and WunderBart Feb 4, 2020
@retrofox retrofox added this to 👀 PRs to review in Navigation block via automation Feb 5, 2020
@retrofox retrofox moved this from 👀 PRs to review to 💻 Issues in progress in Navigation block Feb 6, 2020
Copy link
Contributor

marekhrabe left a comment

This has fixed colors for me in several themes. Sounds like a good change to bring in 👍

I'm wondering if it would make sense to control the text-decoration (usually underline) too, however, that would certainly be done separately.

@retrofox

This comment has been minimized.

Copy link
Contributor Author

retrofox commented Feb 6, 2020

I'm wondering if it would make sense to control the text-decoration (usually underline) too, however, that would certainly be done separately.

It's a good point. Thanks, Mareak.

@retrofox retrofox merged commit 012b0e4 into master Feb 6, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 💻 Issues in progress to ✅ Done Feb 6, 2020
@retrofox retrofox deleted the update/navigation-color-in-anchor-element branch Feb 6, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 6, 2020
chipsnyder added a commit that referenced this pull request Feb 7, 2020
It sets the color of the anchor elements when the Navigation menu has defined a text color. It fixes coloring issues for some themes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.