Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Navigation block: Make function names specific #20039

Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Feb 4, 2020

Description

The navigation block is defining functions whose name looks generic like build_css_colors.
This PR updates the names of functions in the navigation block to make them specific to the block.
In response to the comment raised by @TimothyBJacobs in trac ticket https://core.trac.wordpress.org/ticket/49348#comment:6. Thank you for catching this issue.

How has this been tested?

I verified the navigation block still works as before.

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Feb 4, 2020

@TimothyBJacobs do you think the new function names are adequate? Thank you in advance for any feedback you could provide.

@jorgefilipecosta jorgefilipecosta added this to Needs Review in WordPress 5.4 Must Have Feb 4, 2020
@TimothyBJacobs

This comment has been minimized.

Copy link
Member

TimothyBJacobs commented Feb 4, 2020

Those names make sense to me!

@jorgefilipecosta jorgefilipecosta added this to the Gutenberg 7.4 milestone Feb 4, 2020
@retrofox retrofox self-requested a review Feb 4, 2020
Copy link
Contributor

retrofox left a comment

Tested the whole implementation of the <Navigation /> and it works as expected. 👍

@jorgefilipecosta jorgefilipecosta removed this from the Gutenberg 7.4 milestone Feb 5, 2020
@jorgefilipecosta jorgefilipecosta merged commit 2c587e5 into master Feb 5, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 5, 2020
@jorgefilipecosta jorgefilipecosta deleted the fix/navigation-block-make-function-names-specific branch Feb 5, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 5, 2020
@aduth

This comment has been minimized.

Copy link
Member

aduth commented Feb 7, 2020

Related previous effort (and discussion): #18589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.