Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more format library icons to the icons package #20072

Merged
merged 2 commits into from Feb 7, 2020
Merged

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Feb 6, 2020

This moves:

  • editor-bold renamed as format-bold
  • editor-italic renamed as format-italic
  • editor-strikethrough as format-strikethrough
  • admin-links as link
  • editor-unlink as unlink

to the WordPress icons package.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Feb 7, 2020

editor-bold renamed as format-bold

👍

editor-italic renamed as format-italic

👍

editor-strikethrough as format-strikethrough

👍

admin-links as link
editor-unlink as unlink

Nice one, those names were not great.

I have a preference for "link_off" rather than "unlink", though, as that makes them sort together.

Haven't had a chance to test this branch, though, as you replace the icons be sure to test that the larger 24x24 footprint doesn't break the layout!

@youknowriad youknowriad merged commit 31e7219 into master Feb 7, 2020
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Errored
Details
@youknowriad youknowriad deleted the update/format-icons branch Feb 7, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.