Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more dashicons to the icons package #20091

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Feb 7, 2020

Move a dozen more dashicons to the icons package:

  • All arrow--alt icons are moved as just arrow-
  • Move chevronLeft and right
  • update icon
  • upload icon
  • admin-generic renamed cog
  • edit renamed pencil
  • undo,redo
  • editor-break renamed keyboardReturn
<Dashicon
icon="arrow-down-alt2"
<Icon
icon={ chevronDown }

This comment has been minimized.

Copy link
@youknowriad

youknowriad Feb 7, 2020

Author Contributor

I was wondering if this change is correct. cc @Tug

This comment has been minimized.

Copy link
@Tug

Tug Feb 7, 2020

Contributor

Just did a quick test, they do look a bit smaller in size:
image

The svg path is different so I guess that's expected. I don't think the difference makes a big deal imo.

This comment has been minimized.

Copy link
@jasmussen

jasmussen Feb 7, 2020

Contributor

This is likely because the footprint of the icons have increased from 20x20 to 24x24.

This is noteworthy as all icons in the package, going forward, will have a 24x24 footprint.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Feb 7, 2020

Names seem good to me!

@youknowriad youknowriad merged commit def0768 into master Feb 7, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the update/more-dashicons-to-icon-package branch Feb 7, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.