Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer @wordpress/icons over dashicons in docs and tests #20094

Merged
merged 2 commits into from Feb 7, 2020

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Feb 7, 2020

Should be a harmless PR just updating icons used in docs and tests

@gziolo
gziolo approved these changes Feb 7, 2020
packages/components/src/icon/README.md Show resolved Hide resolved
focusable="false"
height={20}
role="img"
viewBox="0 0 20 20"

This comment has been minimized.

Copy link
@gziolo

gziolo Feb 7, 2020

Member

Do we have changes that adjust CSS for a different size?

Ignore if yes. I’m on mobile and it’s hard to scroll 😅

This comment has been minimized.

Copy link
@youknowriad

youknowriad Feb 7, 2020

Author Contributor

I don't get the question :) I changed the icon here so it's a different viexbox

This comment has been minimized.

Copy link
@gziolo

gziolo Feb 7, 2020

Member

Lol, it's hard to explain. Dashicons have a different size than SVG icon but I think it's handled by the fact that you no longer use Dashicon here. Ignore me :)

This comment has been minimized.

Copy link
@youknowriad

youknowriad Feb 10, 2020

Author Contributor

Yes, for dashicons that are still used we use a trick in viewport (-2) to center them properly even if they're smaller.

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Feb 7, 2020

Nice. What’s the plan for server- side registration of icons? It looks like we are deprecating strings as a way to list them.

@youknowriad youknowriad merged commit a7fbd6e into master Feb 7, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the updaaate/docs-test-icons branch Feb 7, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.