Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi select: remove inserter between selected blocks #20096

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@ellatrix
Copy link
Member

ellatrix commented Feb 7, 2020

Description

Fixes #20092.

How has this been tested?

When multi selecting, there should be no sibling inserter within the selection.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@ellatrix ellatrix added the [Type] Bug label Feb 7, 2020
@ellatrix ellatrix requested a review from youknowriad as a code owner Feb 7, 2020
@jorgefilipecosta jorgefilipecosta added this to Needs Review in WordPress 5.4 Must Have Feb 7, 2020
Copy link
Member

jorgefilipecosta left a comment

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 481840c into master Feb 7, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 7, 2020
@jorgefilipecosta jorgefilipecosta deleted the try/remove-inserter-multi-select branch Feb 7, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.