Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MediaReplaceFlow to select media in media library on replace #20100

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Feb 7, 2020

Description

Closes #20040

Props: @Ringish Thank you for the quick fix.

How has this been tested?

Tested locally.

To test:

  • add any media block
  • select media from library
  • try to replace from library
  • the current media should be selected

Types of changes

I have fixed all the media blocks which implement MediaReplaceControl to have this behavior.

Copy link
Member

jorgefilipecosta left a comment

The change works well, I left a small suggestion.

@@ -28,6 +28,7 @@ import LinkViewer from '../url-popover/link-viewer';

const MediaReplaceFlow = ( {
mediaURL,
mediaId,

This comment has been minimized.

Copy link
@jorgefilipecosta

jorgefilipecosta Feb 7, 2020

Member

mediaId is passed to MediaUpload as value and here is passed as mediaId. Should we be consistent and update the name here?

@jorgefilipecosta jorgefilipecosta moved this from Needs Review to Approved in WordPress 5.4 Must Have Feb 7, 2020
@draganescu draganescu merged commit 6e068d9 into master Feb 10, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Feb 10, 2020
@draganescu draganescu deleted the fix/media-replace-select-image-in-library branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.