Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links: Consistently rebrand as Social Icons #20101

Merged
merged 3 commits into from Feb 10, 2020

Conversation

@mcsf
Copy link
Contributor

mcsf commented Feb 7, 2020

Since #19887, core/social-link was already titled "Social Icon". This PR does the same to parent core/social-links.

Note: This is not the same as renaming the block's name, something which would affect how content is saved. Internally renaming the block isn't off the table, but is a greater commitment that we don't need to make right away.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@mcsf mcsf added the [Block] Social label Feb 7, 2020
@mcsf mcsf requested review from ajitbohra, mkaz, nerrad, ntwb and talldan as code owners Feb 7, 2020
@mcsf mcsf added this to Needs Review in WordPress 5.4 Must Have Feb 7, 2020
@gziolo
gziolo approved these changes Feb 7, 2020
@jorgefilipecosta jorgefilipecosta moved this from Needs Review to Approved in WordPress 5.4 Must Have Feb 8, 2020
mcsf and others added 3 commits Feb 7, 2020
Since #19887, `core/social-link` was already titled "Social Icon". This
PR does the same to parent `core/social-links`.
Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
@mcsf mcsf force-pushed the update/social-links-rename-to-icons branch from c5aa21c to e472ad3 Feb 10, 2020
@gziolo gziolo merged commit 6094fcd into master Feb 10, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Feb 10, 2020
@gziolo gziolo deleted the update/social-links-rename-to-icons branch Feb 10, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.