Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize and document the angle picker component; Rename to AnglePickerControl; #20118

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Feb 8, 2020

Description

This PR stabilizes and documents the angle picker component.

How has this been tested?

I verified in the browser console that the angle picker component was now exposed as wp.components.AnglePicker.

Copy link
Member

chrisvanpatten left a comment

I reviewed the docs and they look good to me, although I'm curious why this is AnglePicker vs. AnglePickerControl?

To me, appending "Control" is an implicit commitment that the component is wrapped in a BaseControl, which is the case here.

@jorgefilipecosta jorgefilipecosta force-pushed the update/stabilize-and-document-the-angle-picker-component branch from cf0cd76 to 4c117bb Feb 9, 2020
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Feb 9, 2020

Hi @chrisvanpatten, I renamed the component to AnglePickerControl.

@jorgefilipecosta jorgefilipecosta changed the title Stabilize and document the angle picker component Stabilize and document the angle picker component; Rename to AnglePickerControl; Feb 9, 2020
Copy link
Member

chrisvanpatten left a comment

Looks great to me!

@jorgefilipecosta jorgefilipecosta force-pushed the update/stabilize-and-document-the-angle-picker-component branch 3 times, most recently from b0f06c9 to d48680d Feb 10, 2020
@jorgefilipecosta jorgefilipecosta force-pushed the update/stabilize-and-document-the-angle-picker-component branch from d48680d to b2132a7 Feb 10, 2020
@jorgefilipecosta jorgefilipecosta merged commit be379ef into master Feb 10, 2020
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Failed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/stabilize-and-document-the-angle-picker-component branch Feb 10, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 10, 2020
"resolved": "https://registry.npmjs.org/node-pre-gyp/-/node-pre-gyp-0.12.0.tgz",
"resolved": false,
Comment on lines -19514 to +19514

This comment has been minimized.

Copy link
@aduth

aduth Feb 12, 2020

Member

I don't see why these changes would be expected here?

When I run npm install on master using the recommended (latest) version of NPM (6.13.7), I see this being flipped back to the value it was previously.

This comment has been minimized.

Copy link
@aduth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.