Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Predefined group text colors don't work on the frontend #20119

Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Feb 8, 2020

Description

Fixes: #20109

The group block did not add the text class for predefined colors so colors did not work as expected on the front end.

How has this been tested?

I added a group block and set a predefined text color.
I added a paragraph inside.
I saved the post. I the paragraph inside the group appeared as expected.

@draganescu

This comment has been minimized.

Copy link
Contributor

draganescu commented Feb 10, 2020

To be Reviewed by @draganescu

Copy link
Contributor

draganescu left a comment

Tested both the fix and the deprecation and they work as described.

@draganescu draganescu merged commit 4c02a4d into master Feb 10, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 10, 2020
@draganescu draganescu deleted the fix/predefined-group-text-colors-dont-work-on-the-frontend branch Feb 10, 2020
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.