Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: Social Link: Consistently rename sites to services #20150

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@aduth
Copy link
Member

aduth commented Feb 10, 2020

Previously: #19887

This pull request seeks to update all functions and references within functions of the Social Link block to reference "services" instead of "sites". Pending confirmation, it appears this was an intended change from #19887, but not all references to the "sites" terminology was included.

Testing Instructions:

There should be no regressions in the insertion, operation, or preview of a Social Links block.

Confirm in code there are no lingering reference to "site".

@aduth aduth requested review from mkaz, mcsf, mtias and gziolo Feb 10, 2020
@aduth aduth added this to Needs Review in WordPress 5.4 Must Have Feb 10, 2020
@aduth aduth added this to the Gutenberg 7.5 milestone Feb 10, 2020
Copy link
Member

jorgefilipecosta left a comment

I tested this PR with the three styles of social links all of them worked well 👍

@aduth aduth merged commit cdd75a1 into master Feb 10, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 10, 2020
@aduth aduth deleted the update/social-link-sites-to-services branch Feb 10, 2020
@mcsf

This comment has been minimized.

Copy link
Contributor

mcsf commented Feb 10, 2020

Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.