Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rotating list of tips to the inserter help panel #20163

Merged
merged 3 commits into from Feb 13, 2020

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Feb 11, 2020

This PR updates the inserter help panel to show a different tip on each render (mount).
This is a static list of tips but we could potentially make it extensible in the future.

Testing instructions

  • Open the inserter
  • Notice that the tip changes each time you open/close the inserter.
@michelleweber

This comment has been minimized.

Copy link

michelleweber commented Feb 11, 2020

I'm assuming the copy is what's here?

For the media files, I'd say "automatically insert" rather than "quickly."

For "transform blocks," I think the update doesn't include enough information, because the word "transform" begs the questions "into what?" Suggestion: "Change a block's type by pressing the block icon on the toolbar."

@mtias

This comment has been minimized.

Copy link
Contributor

mtias commented Feb 12, 2020

Thanks @michelleweber for the suggestions!

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Feb 12, 2020

Applied the suggestions above, thanks.

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Feb 13, 2020

Should we land this first batch of tips?

@mtias
mtias approved these changes Feb 13, 2020
@youknowriad youknowriad merged commit 9d67638 into master Feb 13, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the add/rotating-tips-in-inserter branch Feb 13, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.