Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inline image width pop-up 'wanders' down page #20232

Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Feb 14, 2020

Description

Fix: #19519

How has this been tested?

I added multiple inline images to a paragraph.
I selected an inline image and changed its width in the popover, I verified the popover did not move.
I changed the selected inline image, I verified the popover update its position to be close to the selected inline-image.

Copy link
Contributor

youknowriad left a comment

do you think this component could benefit from a react hooks refactor? or is it too complex?

@jorgefilipecosta jorgefilipecosta added this to Needs Review in WordPress 5.4 Must Have Feb 14, 2020
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Feb 14, 2020

do you think this component could benefit from a react hooks refactor? or is it too complex?

It may benefit from a refactor, but my plan was to cherry-pick this into the next WordPress beta so I avoided a major change to the component to avoid creating some unknown bug.

Copy link
Contributor

youknowriad left a comment

Seems to work as intended

@jorgefilipecosta jorgefilipecosta moved this from Needs Review to Approved in WordPress 5.4 Must Have Feb 17, 2020
@jorgefilipecosta jorgefilipecosta force-pushed the fix/inline-image-width-pop-up-wanders-down-page branch from 08cb019 to 12aff9e Feb 17, 2020
@jorgefilipecosta jorgefilipecosta merged commit 6f55017 into master Feb 17, 2020
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Errored
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Feb 17, 2020
@jorgefilipecosta jorgefilipecosta deleted the fix/inline-image-width-pop-up-wanders-down-page branch Feb 17, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.