Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing label on heading toolbar. #20248

Merged
merged 1 commit into from Feb 19, 2020
Merged

Conversation

@ZebulanStanphill
Copy link
Contributor

ZebulanStanphill commented Feb 14, 2020

Description

The heading level toolbar lacked an aria-label. This PR adds one.
image

@@ -48,6 +48,7 @@ class HeadingToolbar extends Component {
controls={ range( minLevel, maxLevel ).map( ( index ) =>
this.createLevelControl( index, selectedLevel, onChange )
) }
label={ __( 'Change heading level' ) }

This comment has been minimized.

Copy link
@ZebulanStanphill

ZebulanStanphill Feb 14, 2020

Author Contributor

This matches the labels on other controls, e.g. "Change text alignment".

Copy link
Contributor

talldan left a comment

Thanks @ZebulanStanphill, this looks good to go.

@talldan talldan merged commit 59b07cc into master Feb 19, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 19, 2020
@talldan talldan deleted the fix/missing-heading-level-label branch Feb 19, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.