Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the post comments form properly #20279

Merged
merged 1 commit into from Feb 18, 2020
Merged

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Feb 18, 2020

The comment_form php function outpus the HTML inline which means it doesn't get rendered properly when used as a block. This PR fixes by catching the output and outputting it to the right position.

Testing instructions

  • Add a "Post comment" block to your post
  • Make sure the form shows up at the right position in the frontend.
@epiqueras epiqueras merged commit cba6dfb into master Feb 18, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@epiqueras epiqueras deleted the fix/post-comments-form-render branch Feb 18, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.