Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media: Fix flow for gallery creation and editing #20287

Merged
merged 2 commits into from Feb 18, 2020

Conversation

@anthonyburchell
Copy link
Contributor

anthonyburchell commented Feb 18, 2020

Description

See bug report at #17641 (comment). An issue raised that Gallery flows skipped the edit gallery state and also added every image in the image library to the gallery. 馃槄

This PR restores the Post flow to the gallery frames so that we 1) restore the sidebar that is important to the edit gallery state. 2) Fix the issue where all images are added to the gallery.

This PR also restores the ability to "add to gallery"

@mcsf
mcsf approved these changes Feb 18, 2020
Copy link
Contributor

mcsf left a comment

Thanks for the quick fix, @anthonyburchell! This definitely does it for me.

@mcsf mcsf changed the title 17642 restores Post flow to Gallery for regression fix Media: Fix flow for gallery creation and editing Feb 18, 2020
@anthonyburchell

This comment has been minimized.

Copy link
Contributor Author

anthonyburchell commented Feb 18, 2020

Thanks for testing @mcsf !

I had one change that needed to happen in the doc block to reflect the changes. This should be good now. :)

@mcsf mcsf added this to Approved in WordPress 5.4 Must Have Feb 18, 2020
@mcsf mcsf merged commit c58b322 into WordPress:master Feb 18, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Feb 18, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
jorgefilipecosta added a commit that referenced this pull request Feb 24, 2020
* restores Post flow to gallery frames

* fixes docs to reflect proper Post frame

Props anthonyburchell
jorgefilipecosta added a commit that referenced this pull request Feb 24, 2020
* restores Post flow to gallery frames

* fixes docs to reflect proper Post frame

Props anthonyburchell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.