Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menus endpoints. #20292

Merged
merged 5 commits into from Mar 18, 2020
Merged

Add menus endpoints. #20292

merged 5 commits into from Mar 18, 2020

Conversation

@spacedmonkey
Copy link
Contributor

spacedmonkey commented Feb 18, 2020

Description

Add menu endpoints from https://github.com/WP-API/menus-endpoints

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@spacedmonkey spacedmonkey requested a review from TimothyBJacobs as a code owner Feb 18, 2020
@spacedmonkey

This comment has been minimized.

Copy link
Contributor Author

spacedmonkey commented Feb 28, 2020

CC // @marekhrabe @draganescu

@draganescu

This comment has been minimized.

Copy link
Contributor

draganescu commented Mar 1, 2020

@spacedmonkey this is awesome news for the Navigation block :)

Is there a Trac ticket we could tie this PR to?

@spacedmonkey

This comment has been minimized.

Copy link
Contributor Author

spacedmonkey commented Mar 2, 2020

@draganescu The original ticket is https://core.trac.wordpress.org/ticket/40878
However, I have been working on the feature plugin, so for history, it is best to look there.

This PR has a lot of code in, but barring some very small tweaks ( to change the name from wp/v2 to __experimental), it is a copy and paste from https://github.com/WP-API/menus-endpoints which as already been code reviewed by @TimothyBJacobs and @kadamwhite . This PR should quick to get merged.

@draganescu

This comment has been minimized.

Copy link
Contributor

draganescu commented Mar 2, 2020

My bad @spacedmonkey :) I didn't pay attention to which repo this is and I thought it was a patch for core (a PR against the wordpress-develop master) 😁

@paaljoachim

This comment has been minimized.

Copy link

paaljoachim commented Mar 11, 2020

I do believe that
@getdave @retrofox
might want to know about this PR.

@noisysocks noisysocks added this to PRs in progress in Navigation in nav-menus.php via automation Mar 17, 2020
Copy link
Contributor

draganescu left a comment

I have worked with this PR in #18869 and have had no issues. Also considering:

  • all endpoints are 'hidden' behind __experiemental,
  • the code comes straight from the feature plugin where it has been reviewed extensively by the REST API team

we can merge this and use it for the issues that need it.

@draganescu draganescu merged commit 56ec52e into WordPress:master Mar 18, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Navigation in nav-menus.php automation moved this from PRs in progress to Done Mar 18, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 18, 2020
@getdave

This comment has been minimized.

Copy link
Contributor

getdave commented Mar 20, 2020

I'm really pleased to see this got merged 🎉 🎉 🎉 Great work everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.