Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block: fix background color for dark themes #20296

Merged
merged 1 commit into from Feb 18, 2020

Conversation

@simison
Copy link
Member

simison commented Feb 18, 2020

Description

Fix spacer block background color in "selected" state:

Before

Screenshot 2020-02-18 at 21 47 50

After

Screenshot 2020-02-18 at 21 47 15

Used the same background color as placeholder component has:

image

How has this been tested?

Screenshots

Types of changes

Bugfix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@mtias
mtias approved these changes Feb 18, 2020
@simison simison merged commit ec91b39 into master Feb 18, 2020
3 checks passed
3 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@simison simison deleted the fix/spacer-block-dark-theme branch Feb 18, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.