Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env: Support wp-config.php overrides. #20352

Merged
merged 4 commits into from Feb 21, 2020

Conversation

@epiqueras
Copy link
Contributor

epiqueras commented Feb 21, 2020

Closes #19972.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Feb 21, 2020

Size Change: 0 B

Total Size: 864 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-editor/style-rtl.css 9.78 kB 0 B
build/block-editor/style.css 9.77 kB 0 B
build/block-library/editor-rtl.css 7.67 kB 0 B
build/block-library/editor.css 7.67 kB 0 B
build/block-library/index.js 114 kB 0 B
build/block-library/style-rtl.css 7.47 kB 0 B
build/block-library/style.css 7.48 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 190 kB 0 B
build/components/style-rtl.css 16.1 kB 0 B
build/components/style.css 16 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 90.7 kB 0 B
build/edit-post/style-rtl.css 8.69 kB 0 B
build/edit-post/style.css 8.68 kB 0 B
build/edit-site/index.js 4.58 kB 0 B
build/edit-site/style-rtl.css 2.77 kB 0 B
build/edit-site/style.css 2.76 kB 0 B
build/edit-widgets/index.js 4.36 kB 0 B
build/edit-widgets/style-rtl.css 2.8 kB 0 B
build/edit-widgets/style.css 2.79 kB 0 B
build/editor/editor-styles-rtl.css 327 B 0 B
build/editor/editor-styles.css 328 B 0 B
build/editor/index.js 45.1 kB 0 B
build/editor/style-rtl.css 4.13 kB 0 B
build/editor/style.css 4.11 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 500 B 0 B
build/format-library/style.css 501 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.45 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 215 B 0 B
build/list-reusable-blocks/style.css 216 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 878 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@noisysocks

This comment has been minimized.

Copy link
Member

noisysocks commented Feb 21, 2020

Why only set config on the development environment? My understanding was that the two environments are identical except for that they use different databases.

I think let's remove WORDPRESS_DEBUG from the generated docker-compose.yml and instead default config to { WP_DEBUG: true, SCRIPT_DEBUG: true }. That way we have sensible defaults that can be overridden using .wp-env.json.

@epiqueras

This comment has been minimized.

Copy link
Contributor Author

epiqueras commented Feb 21, 2020

Why only set config on the development environment? My understanding was that the two environments are identical except for that they use different databases.

I thought certain variables that log extra output could break tests, but I guess that might also be intended in some cases, and if we run into issues, we can always introduce config.development and config.tests.

I think let's remove WORDPRESS_DEBUG from the generated docker-compose.yml and instead default config to { WP_DEBUG: true, SCRIPT_DEBUG: true }. That way we have sensible defaults that can be overridden using .wp-env.json.

Good idea, done.

packages/env/lib/env.js Outdated Show resolved Hide resolved
packages/env/lib/env.js Outdated Show resolved Hide resolved
packages/env/lib/env.js Outdated Show resolved Hide resolved
@epiqueras

This comment has been minimized.

Copy link
Contributor Author

epiqueras commented Feb 21, 2020

Done 😄

packages/env/lib/env.js Outdated Show resolved Hide resolved
Copy link
Member

noisysocks left a comment

Perfect! Tested by setting some constants in .wp-env.override.json and inspecting them in /wp-admin/site-health.php?tab=debug 👍

@noisysocks noisysocks merged commit 5343dfc into master Feb 21, 2020
3 checks passed
3 checks passed
build
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@noisysocks noisysocks deleted the add/wp-env-support-for-wp-config-overrides branch Feb 21, 2020
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 21, 2020
jorgefilipecosta added a commit that referenced this pull request Mar 2, 2020
* Env: Support wp-config.php overrides.

* Env: Move WORDPRESS_DEBUG to work through the new config.

* Fix bugs.

* Handle string values.
jorgefilipecosta added a commit that referenced this pull request Mar 2, 2020
* Env: Support wp-config.php overrides.

* Env: Move WORDPRESS_DEBUG to work through the new config.

* Fix bugs.

* Handle string values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tightening Up
  
Awaiting triage
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.