Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for block settings menu #20357

Open
wants to merge 5 commits into
base: master
from

Conversation

@nosolosw
Copy link
Member

nosolosw commented Feb 21, 2020

This PR adds a new e2e test for the plugins API: the PluginBlockSettingsMenuItem SlotFill.

@nosolosw nosolosw requested review from ajitbohra, nerrad, ntwb and talldan as code owners Feb 21, 2020
@nosolosw nosolosw self-assigned this Feb 21, 2020
@nosolosw nosolosw requested a review from gziolo Feb 21, 2020
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Feb 21, 2020

Size Change: +2.03 kB (0%)

Total Size: 866 kB

Filename Size Change
build/annotations/index.js 3.43 kB -1 B
build/autop/index.js 2.58 kB +1 B
build/block-directory/index.js 6.02 kB +1 B
build/block-editor/index.js 104 kB +522 B (0%)
build/block-editor/style-rtl.css 10.5 kB +710 B (6%) 🔍
build/block-editor/style.css 10.5 kB +715 B (6%) 🔍
build/block-library/editor-rtl.css 7.66 kB -13 B (0%)
build/block-library/editor.css 7.66 kB -8 B (0%)
build/block-library/index.js 116 kB +1.97 kB (1%)
build/block-library/style-rtl.css 7.49 kB +16 B (0%)
build/block-library/style.css 7.5 kB +16 B (0%)
build/block-serialization-default-parser/index.js 1.65 kB +1 B
build/blocks/index.js 57.6 kB +4 B (0%)
build/components/index.js 191 kB +835 B (0%)
build/components/style-rtl.css 15.5 kB -529 B (3%)
build/components/style.css 15.5 kB -535 B (3%)
build/compose/index.js 5.76 kB -2 B (0%)
build/data-controls/index.js 1.03 kB -1 B
build/data/index.js 8.22 kB -3 B (0%)
build/date/index.js 5.37 kB +4 B (0%)
build/deprecated/index.js 772 B +1 B
build/dom-ready/index.js 568 B -1 B
build/dom/index.js 3.06 kB -1 B
build/edit-post/index.js 90.9 kB +230 B (0%)
build/edit-post/style-rtl.css 8.54 kB -159 B (1%)
build/edit-post/style.css 8.54 kB -151 B (1%)
build/edit-site/index.js 4.63 kB +50 B (1%)
build/edit-site/style-rtl.css 2.51 kB -257 B (10%) 👏
build/edit-site/style.css 2.51 kB -255 B (10%) 👏
build/edit-widgets/index.js 4.42 kB +65 B (1%)
build/edit-widgets/style-rtl.css 2.59 kB -208 B (8%)
build/edit-widgets/style.css 2.58 kB -207 B (8%)
build/editor/editor-styles-rtl.css 325 B -2 B (0%)
build/editor/editor-styles.css 327 B -1 B
build/editor/index.js 44.6 kB -520 B (1%)
build/editor/style-rtl.css 4.01 kB -115 B (2%)
build/editor/style.css 4 kB -111 B (2%)
build/element/index.js 4.45 kB -2 B (0%)
build/format-library/index.js 7.6 kB +2 B (0%)
build/format-library/style-rtl.css 502 B +2 B (0%)
build/format-library/style.css 502 B +1 B
build/html-entities/index.js 622 B +1 B
build/i18n/index.js 3.48 kB +37 B (1%)
build/is-shallow-equal/index.js 710 B -1 B
build/keyboard-shortcuts/index.js 2.3 kB +4 B (0%)
build/list-reusable-blocks/style-rtl.css 226 B +11 B (4%)
build/list-reusable-blocks/style.css 226 B +10 B (4%)
build/media-utils/index.js 4.85 kB -1 B
build/nux/index.js 3.02 kB +1 B
build/plugins/index.js 2.54 kB +1 B
build/priority-queue/index.js 780 B -98 B (12%) 👏
build/rich-text/index.js 14.3 kB -3 B (0%)
build/server-side-render/index.js 2.54 kB -2 B (0%)
build/token-list/index.js 1.27 kB -1 B
build/url/index.js 4 kB +1 B
build/warning/index.js 1.14 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/escape-html/index.js 733 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.49 kB 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Feb 26, 2020

did you omit commiting the test file? I only see changes to the plugin?

@nosolosw

This comment has been minimized.

Copy link
Member Author

nosolosw commented Feb 26, 2020

This is embarrasing 😅 I thought that I have done it, but it turns out that I didn't. Pushed it on 19431c4

@nosolosw nosolosw requested a review from youknowriad Feb 26, 2020
Copy link
Contributor

youknowriad left a comment

LGTM 👍 Thanks for the update

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Feb 26, 2020

Looks like it's breaking in travis though.

nosolosw added 3 commits Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.