Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LatestPosts] Don't trim manual excerpts #20432

Merged
merged 2 commits into from Mar 9, 2020

Conversation

@draganescu
Copy link
Contributor

draganescu commented Feb 25, 2020

Description

Closes #20327 Based on input from #20313

This PR makes the LatestPosts block respect manual excerpts by showing post.excerpt.raw if it exists - without trimming it.

How has this been tested?

Tested locally by:

  1. Making sure you have a bunch of posts that have manual excerpts and some which don't
  2. Creating a new post
  3. Adding a LatestPosts block
  4. Set the block to Show post content -> Excerpt and Excerpt length to 10 words/
  5. Observe that manual excerpts are not trimmed.

Screenshots

Types of changes

Non breaking changes to the LatestPosts block edit function.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Feb 25, 2020

Size Change: +12 B (0%)

Total Size: 864 kB

Filename Size Change
build/block-library/index.js 115 kB +12 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-editor/style-rtl.css 10.6 kB 0 B
build/block-editor/style.css 10.6 kB 0 B
build/block-library/editor-rtl.css 7.36 kB 0 B
build/block-library/editor.css 7.36 kB 0 B
build/block-library/style-rtl.css 7.52 kB 0 B
build/block-library/style.css 7.52 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.75 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.64 kB 0 B
build/edit-post/style.css 8.64 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.48 kB 0 B
build/edit-site/style.css 2.48 kB 0 B
build/edit-widgets/index.js 4.44 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.98 kB 0 B
build/editor/style.css 3.97 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.11 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.48 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@draganescu draganescu force-pushed the add/respect-manual-excerpt-latest-posts branch from 00a371d to a9d3ffe Mar 9, 2020
Copy link
Member

jorgefilipecosta left a comment

Worked well on my tests 👍

@jorgefilipecosta jorgefilipecosta moved this from Needs Review to Approved in WordPress 5.4 Must Have Mar 9, 2020
@draganescu draganescu merged commit 50d9fdc into master Mar 9, 2020
3 checks passed
3 checks passed
build
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Mar 9, 2020
@draganescu draganescu deleted the add/respect-manual-excerpt-latest-posts branch Mar 9, 2020
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 9, 2020
jorgefilipecosta added a commit that referenced this pull request Mar 9, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 9, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 9, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 9, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 9, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 10, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
jorgefilipecosta added a commit that referenced this pull request Mar 10, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts

* removed the reset to raw excerpt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.