Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing accessibility attributes in the svg icons #20538

Conversation

@donmhico
Copy link
Contributor

donmhico commented Feb 28, 2020

Closes #20466.

Description

This PR adds role="img" aria-hidden="true" focusable="false" attributes in all of the available Social Icons in Social Icons Block.

Screenshots

Kapture 2020-02-29 at 0 56 11

Types of changes

Bug fix.

Checklist:

  • [ X ] My code is tested.
  • [ X ] My code follows the WordPress code style.
@donmhico donmhico requested a review from mkaz as a code owner Feb 28, 2020
Copy link
Member

jorgefilipecosta left a comment

The change looks good in my tests. @mcsf I'm planning on including this PR as part of the next WordPress RC could you double-check if it is ok to backport the PR?

@jorgefilipecosta jorgefilipecosta merged commit 035fce1 into WordPress:master Mar 1, 2020
3 checks passed
3 checks passed
build
Details
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
WordPress 5.4 Must Have automation moved this from Approved to Done Mar 1, 2020
@afercia

This comment has been minimized.

Copy link
Contributor

afercia commented Mar 2, 2020

@donmhico thanks! 🎉

@jorgefilipecosta thanks for including this in the WP 5.4 "must have".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.