Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick PR's for WordPress 5.4 RC 3 #20937

Merged
merged 4 commits into from Mar 16, 2020
Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Mar 16, 2020

Description

This PR cherry picks the following PR's into wp/trunk:

PR titleAuthorChange required for cherry-picking
Components: Refactor SlotFill@diegohazUpdate snapshots
Fix intermittent RichText e2e test failure@youknowriadUpdate snapshots
Fix: ResponsiveWrapper can not handle cases with small dimensions@jorgefilipecostaUse useResizeAware directly from react-resize-aware (package was already in use by the components package) instead of useResizeObserver from wordpress/compose (in trunk the hook is not available).
Fix: Cover block does not contain a class for predefined gradients@jorgefilipecosta-

cc: @youknowriad, @aduth, @gziolo

These PR's will be part of WordPress 5.4 RC 3.

How has this been tested?

I did some smoke tests and verified the branch, in fact, contained the expected fixes.

@jorgefilipecosta jorgefilipecosta changed the title Cherry Pick PR's for WordPress 5.4 RC 2 Cherry Pick PR's for WordPress 5.4 RC 3 Mar 16, 2020
@aduth
aduth approved these changes Mar 16, 2020
Copy link
Member

aduth left a comment

Looks good and tests well in some quick round of testing of the original issues 👍 Thanks for summarizing the conflict resolution notes as well.

@jorgefilipecosta jorgefilipecosta merged commit 257968b into wp/trunk Mar 16, 2020
4 checks passed
4 checks passed
pull-request-automation
Details
pull-request-automation
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the wp/trunk-5-4-0-rc-3 branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.